Implement ZAdd and Zscore #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuhuynh27
requested review from
yampml,
axblueblader,
duongcongtoai and
haphananhtuan
tuhuynh27
reviewed
Dec 16, 2021
| val result = jedis.zscore("zset", "foo"); | ||
| assertNull(result); | ||
| } finally { | ||
| jedis.del("zset"); |
There was a problem hiding this comment.
Hi @the123saurav, we might don't need this finally block because we already reset the database after every @Test method
There was a problem hiding this comment.
Ohh missed it completely, will remove.
|
Great work @the123saurav 🎉 , also we need to update docs for command on the website too, for example https://github.com/keva-dev/keva/pull/55/files#diff-f0a6bf8edd363560735f8cabf8ad1b8f62d6d171c968ad63d60497d2ef1fbb56 |
the123saurav
force-pushed
the
zadd-copy
branch
from
16cfec7
to
b509dfc
Compare
|
Incorporated changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a Sorted Set data structure and couple of basic commands, namely ZAdd and ZScore