Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when commit hash is empty #93

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

kevalpatel2106
Copy link
Owner

Links to issues/other PRs 🔗

@kevalpatel2106 kevalpatel2106 self-assigned this Sep 12, 2022
@kevalpatel2106 kevalpatel2106 added the Type > bug Issues related to something isn't working or crashing label Sep 12, 2022
@github-actions github-actions bot added the size/S Small size PR label Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Base: 50.19% // Head: 50.19% // No change to project coverage 👍

Coverage data is based on head (5e85256) compared to base (1f8fc91).
Patch coverage: 50.00% of modified lines in pull request are covered.

❗ Current head 5e85256 differs from pull request most recent head 92abdc3. Consider uploading reports for the commit 92abdc3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   50.19%   50.19%           
=======================================
  Files         323      323           
  Lines        4196     4196           
  Branches      387      387           
=======================================
  Hits         2106     2106           
  Misses       2029     2029           
  Partials       61       61           
Impacted Files Coverage Δ
...nnector/bitrise/network/mapper/CommitMapperImpl.kt 0.00% <0.00%> (ø)
...in/java/com/kevalpatel2106/entity/id/CommitHash.kt 81.81% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added size/M Medium size PR and removed size/S Small size PR labels Sep 15, 2022
@kevalpatel2106 kevalpatel2106 merged commit bda0e8f into main Sep 15, 2022
@kevalpatel2106 kevalpatel2106 deleted the fix-crash-because-of-commithash branch September 15, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Medium size PR Type > bug Issues related to something isn't working or crashing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Crash when commit hash is empty
1 participant