Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set the Age header in the cached object #4

Merged
merged 1 commit into from
Sep 22, 2019

Conversation

erikdubbelboer
Copy link
Contributor

Set it on the ResponseWriter directly. Otherwise we have a race condition where multiple requests might cause concurrent writes and reads to the headers of the cached object.

Set it on the ResponseWriter directly. Otherwise we have a race
condition where multiple requests might cause concurrent writes and
reads to the headers of the cached object.
Copy link
Owner

@kevburnsjr kevburnsjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, this is clearly an error as evidenced by the fact that the method signature accepts w but that argument is never referenced within the function.

@kevburnsjr kevburnsjr merged commit 8498327 into kevburnsjr:master Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants