Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests #2

Closed
kevcjones-archived opened this issue Nov 29, 2017 · 2 comments
Closed

Add tests #2

kevcjones-archived opened this issue Nov 29, 2017 · 2 comments
Assignees
@kevcjones-archived
Labels
enhancement
Projects
Launch v1.1

Comments

@kevcjones-archived
Copy link
Collaborator

From @kevcjones on November 13, 2017 9:48

Needs some tests in place, unit and some e2e for the demo so i know if changes i accept might break the code base.

Copied from original issue: kevcjones-archived/angularx-bootstrap-modal#5
@kevcjones-archived kevcjones-archived mentioned this issue Nov 29, 2017
Closed
@kevcjones-archived kevcjones-archived added this to To Do in Launch v1.1 via automation Nov 29, 2017
kevcjones-archived pushed a commit that referenced this issue Nov 29, 2017
@KevinCJones
dialog remove pass #2
5a18e5b
@kevcjones-archived kevcjones-archived mentioned this issue Nov 30, 2017
Closed
@kevcjones-archived kevcjones-archived self-assigned this Dec 3, 2017
@kevcjones-archived
Copy link
Collaborator Author

Made some good progress today
image

Setup JEST - looked over at the yeoman angular library project for inspiration. Testing theirs, jest seemed to have much less boilerplate than the jasmine + karma one.

@kevcjones-archived
Copy link
Collaborator Author

Now i just need to really look at what is worth testing on this suite of coupled components..

@kevcjones-archived kevcjones-archived moved this from To Do to Doing it in Launch v1.1 Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevcjones-archived kevcjones-archived

Labels
enhancement
Projects
No open projects
Launch v1.1
  
Doing it
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevcjones-archived