Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component inside modal with @HostListener('document.click') doesn't work #69

Closed
yadue opened this issue Mar 30, 2020 · 1 comment
Closed

Component inside modal with @HostListener('document.click') doesn't work #69

yadue opened this issue Mar 30, 2020 · 1 comment

Comments

@yadue
Copy link
Contributor

yadue commented Mar 30, 2020

If you have modal set, and inside that modal you put any component with @HostListener('document.click')
then the event is not being propagated. It's strictly related to stopPropagation inside SimpleModalWrapperComponent.

All angular events should work as expected.
yadue added a commit to ziflow/ngx-simple-modal that referenced this issue Mar 30, 2020
@yadue
Fixing issues with kevcjones#69, @HostListener does not work in modal…
fb2d224 
… context
kevcjones-archived pushed a commit that referenced this issue Apr 1, 2020
@yadue
Fixing issues with #69, @HostListener does not work in modal context (#…
55e41b1 
…70)

* Fixing issues with #69, @HostListener does not work in modal context

* Formatting

* Moved declaration

Co-authored-by: Pawel Czekaj <pawel.czekaj@ziflow.com>
@kevcjones-archived
Copy link
Collaborator

Many thanks for contributing.
Is now released - https://www.npmjs.com/package/ngx-simple-modal/v/1.4.12

kevcjones-archived pushed a commit that referenced this issue Aug 28, 2020
@yadue
Allow to dynamically change options closeOnClickOutside (#71)
8ddeb60 
* Fixing issues with #69, @HostListener does not work in modal context

* Formatting

* Moved declaration

* Update simple-modal-holder.component.ts

allow to dynamically change options closeOnClickOutside

Co-authored-by: Pawel Czekaj <pawel.czekaj@ziflow.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevcjones-archived @yadue