Improve Result API

kevgo · Aug 18, 2020 · 9931511 · 9931511
1 parent a04e8c5
commit 9931511
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/README.md b/README.md
@@ -125,9 +125,9 @@ const result = observable.waitForEnd()
 assert.equal(result, {
   exitCode: 0,
   killed: false,
-  stdOutput: "... content from STDOUT ...",
-  errOutput: "... content from STDERR ...",
-  combinedOutput: "... content from both STDOUT and STDERR ...",
+  stdText: "... content from STDOUT ...",
+  errText: "... content from STDERR ...",
+  combinedText: "... content from both STDOUT and STDERR ...",
 })
 ```
 

diff --git a/test/kill-test.ts b/test/kill-test.ts
@@ -23,9 +23,9 @@ test("ObservableProcess.kill()", async function () {
   await assertIsNotRunning(port)
   assert.equal(result.killed, true, "process should be killed")
   assert.equal(result.exitCode, -1)
-  assert.equal(result.stdOutput, "online\n")
-  assert.equal(result.errOutput, "")
-  assert.equal(result.combinedOutput, "online\n")
+  assert.equal(result.stdText, "online\n")
+  assert.equal(result.errText, "")
+  assert.equal(result.combinedText, "online\n")
 })
 
 async function assertIsRunning(port: number) {

diff --git a/test/wait-for-end-test.ts b/test/wait-for-end-test.ts
@@ -11,17 +11,17 @@ test("process ends before calling it", async function () {
   const result = await observable.waitForEnd()
   assert.deepEqual(result.exitCode, 7)
   assert.deepEqual(result.killed, false)
-  assert.deepEqual(result.stdOutput, "hello\n")
-  assert.deepEqual(result.errOutput, "")
-  assert.deepEqual(result.combinedOutput, "hello\n")
+  assert.deepEqual(result.stdText, "hello\n")
+  assert.deepEqual(result.errText, "")
+  assert.deepEqual(result.combinedText, "hello\n")
 })
 
 test("process still running when calling it", async function () {
   const observable = start(["node", "-e", "setTimeout(function() { console.log('finally'); process.exit(8)}, 10)"])
   const result = await observable.waitForEnd()
   assert.equal(result.exitCode, 8)
   assert.equal(result.killed, false)
-  assert.equal(result.stdOutput, "finally\n")
-  assert.equal(result.errOutput, "")
-  assert.equal(result.combinedOutput, "finally\n")
+  assert.equal(result.stdText, "finally\n")
+  assert.equal(result.errText, "")
+  assert.equal(result.combinedText, "finally\n")
 })