Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fx should no longer be Monad #265

Closed
kevin-lee opened this issue Aug 10, 2021 · 0 comments · Fixed by #268
Closed

Fx should no longer be Monad #265

kevin-lee opened this issue Aug 10, 2021 · 0 comments · Fixed by #268
Assignees
Labels
task Task v1 Effectie v1
Milestone

Comments

@kevin-lee
Copy link
Owner

Task

Summary

Fx should no longer be Monad.

Project Details

Version: 1.14.0

Description

Fx being Monad may work well in a normal case like

def foo[F[_]: Fx]: R = ???

However, it may not work if it's used with Resource from Cats Effect.
When

Resource.make(someResource)(resource => ???)

The make requires Functor[F] typeclass which might be conflict with Fx itself since Monad[F] is also Functor[F] (Monad[F] with Applicative[F] with Functor[F])

So the best way to fix it, at least for now, is to remove Monad from Fx.

@kevin-lee kevin-lee added the task Task label Aug 10, 2021
@kevin-lee kevin-lee added this to the milestone21 milestone Aug 10, 2021
@kevin-lee kevin-lee self-assigned this Aug 10, 2021
kevin-lee added a commit that referenced this issue Aug 11, 2021
@kevin-lee kevin-lee added the v1 Effectie v1 label Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Task v1 Effectie v1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant