Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #352 - Change Effectful to fx and move to core / also move possible error syntax to core #353

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

kevin-lee
Copy link
Owner

Close #352 - Change Effectful to fx and move to core / also move possible error syntax to core

@kevin-lee kevin-lee added this to the milestone23 milestone Jan 19, 2022
@kevin-lee kevin-lee self-assigned this Jan 19, 2022
@github-actions github-actions bot added pr PR v2 Effectie v2 labels Jan 19, 2022
@kevin-lee kevin-lee force-pushed the task/352/fx-error-syntax-to-core branch from 934735e to efbad52 Compare January 19, 2022 11:34
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #353 (efbad52) into main (1bf0c21) will decrease coverage by 0.74%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
- Coverage   82.07%   81.33%   -0.75%     
==========================================
  Files          51       50       -1     
  Lines         569      525      -44     
  Branches        2        2              
==========================================
- Hits          467      427      -40     
+ Misses        102       98       -4     
Impacted Files Coverage Δ
.../src/main/scala-2/effectie/cats/syntax/error.scala 100.00% <ø> (ø)
.../src/main/scala-2/effectie/cats/syntax/error.scala 100.00% <ø> (ø)
core/src/main/scala-2/effectie/syntax/fx.scala 100.00% <ø> (ø)
...x/src/main/scala/effectie/monix/syntax/error.scala 100.00% <ø> (ø)
core/src/main/scala-2/effectie/syntax/error.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bf0c21...efbad52. Read the comment docs.

@kevin-lee kevin-lee merged commit 03b0d95 into main Jan 19, 2022
@kevin-lee kevin-lee deleted the task/352/fx-error-syntax-to-core branch January 19, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr PR v2 Effectie v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Effectful to fx and move to core / also move possible error syntax to core
1 participant