btree: update value to null, after insert

[Horki]

#92 fix for updating value to null

[kevin-wayne]

Thanks. Does this affect correctness? The documentation says that only the key and next fields of internal nodes are used. But still probably worth nulling out to prevent loitering.

[Horki]

My fix doesn't have a negative effect on correctness, I even wrote some simple unit tests for validation

[kevin-wayne]

Right, just confirming that it has no positive effects on correctness either. It's a stylistic improvement and fixes a loitering (memory) bug.

[Horki]

@kevin-wayne feel free to close it, but I taught the fix was helpful

[Horki]

@kevin-wayne my commit didn't remove a "final" keyword from "val", but I was aware of that, and it's really unfair from you that made the update, without giving me any kudos for finding a bug.

From that, I can only assume, if I find another bug in algs4 code, I wouldn't report it furthermore.

Kind regards,
Ivan Zvonimir Horvat

PS
You should be really ashamed

[kevin-wayne]

I use a local system to commit all changes (which predates this git repo and enables me to publish to the booksite, syntax highlight, add to algs4.jar, and then sync to git). That is, git is just an externally facing way to report bugs and distribute the code, but the workflow does not allow me to accept any pull requests directly. I didn't realize that would cause anyone to feel that they weren't being properly credited. But I certainly credit you here!

[Horki]

@kevin-wayne commit in algs4 repo would mean something, however, kudos here is pretty invisible and therefore useless.
It would be nice to have a notice about the pull requests policy in README file, so there won't be any confusion.

[DyslexicAtheist]

Right, just confirming that it has no positive effects on correctness either. It's a stylistic improvement and fixes a loitering (memory) bug.

how can it be a "stylistic improvement" when in the same sentence it's also a "memory bug". Sounds like downplaying tbh.