VCR Not Sending Client Certificate when wrapping Requests

[fxfitz]

When using VCR and attempting to send a client certificate to a webserver (as seen below), VCR does not include the certificate in the packets being sent out.

This can be confirmed by looking at a Wireshark capture (screenshot). When the client presents the certificate, you can see the 'Certificates Length' is actually 0.

This works as expected when not using VCR.

creds_resp = requests.get(computer.creds_href,
                              cert=client_cert,
                              verify=CA_FILENAME)

[colonelpanic8]

Seems likely that this is because we only forward certain values explicitly to the actual connection.

vcrpy/vcr/stubs/__init__.py

Line 176 in 2ac3fa9

def putrequest(self, method, url, *args, **kwargs):

vcrpy/vcr/stubs/__init__.py

Line 251 in 2ac3fa9

self.real_connection.request(

We probably need to store the data coming in as args, kwargs there and pass it on appropriately.

But thats all just a guess.

[agriffis]

@fxfitz You didn't happen to investigate this any further, did you?

[fxfitz]

Sadly, no, I haven't.

[kevin1024]

I'd like to write a test for this, but since this happens at the protocol layer I'm not sure how to assert that the certificate is included.

[kevin1024]

The SSL also changed in py2.7+ to use SSLContext instead of as args to the HTTPConnection object. So this might be version-dependent.

[neozenith]

A lot of changes have happened to VCRpy since this ticket was opened. As this ticket has become stale and we have a lot of old tickets that need to be groomed, I'm closing this for now to make it easier to see what is still relevant.

However if it is still needed, please feel free to re-open or create a new ticket.

Thanks! 🙏