Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Reorganize stages to run more like the jwst pipeline #513

Open
1 task done
taylorbell57 opened this issue Apr 3, 2023 · 0 comments
Open
1 task done
Assignees
Labels
enhancement New feature or request

Comments

@taylorbell57
Copy link
Collaborator

taylorbell57 commented Apr 3, 2023

Instrument

Other (any stage)

What is your suggestion?

At present, our main files for each stage are quite massive and make it very challenging to get an overview of what is happening in the stage. It is also very challenging for users to swap out custom versions of functions without editing large chunks of the source code. And changing the order in which operations are performed in Stage 3 is also impossible without directly editing the source code.

Ideally, our main files for each stage should basically just be a for-loop that iterates over a list of functions that will be called in order, similar to how the jwst pipeline works. That way, if you want to skip doing background subtraction, then you can easily remove that function from the list. And if you want to replace the background subtraction method with one of your own, then you just replace that index in the list.

This is primarily an issue with Stages 3-4 but is worth considering for Stages 5-6 as well.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@taylorbell57 taylorbell57 added the enhancement New feature or request label Apr 3, 2023
@taylorbell57 taylorbell57 self-assigned this Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

1 participant