Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: bg_disp (now called bg_row_by_row), bg_dir, and isrotate all seem to control the same thing #675

Closed
taylorbell57 opened this issue Aug 1, 2024 · 2 comments · Fixed by #693
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@taylorbell57
Copy link
Collaborator

This seems problematic. I'll need to look into this

Originally posted by @kevin218 in #632 (comment)

@taylorbell57 taylorbell57 added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 1, 2024
@taylorbell57
Copy link
Collaborator Author

@kevin218, this may be worth addressing before v1.0 since it could result in some meaningful changes to ECF parameters

@kevin218
Copy link
Owner

@taylorbell57 After a few tests, I've managed to simplify the code so that bg_dir and isrotate do not need to be specified in s3_meta.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants