Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fade Out is too fast #22

Closed
appzuka opened this issue Feb 28, 2013 · 1 comment
Closed

Fade Out is too fast #22

appzuka opened this issue Feb 28, 2013 · 1 comment

Comments

@appzuka
Copy link

appzuka commented Feb 28, 2013

The slideEaseDuration only controls the speed at which the div fades in. To make it also fade out smoothly I would recommend the change below:

Line 973 from: .siblings().css('display', 'none');
to.siblings().fadeOut(self.options.slideEaseDuration);

@KevinBatdorf
Copy link
Owner

Just pushed an update but I changed it to this instead:

.siblings().fadeTo(self.options.fadeOutDuration, 0);

And I added two options to the control the fade in and fade out.

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants