disableInjectedStyle option #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinchappell
added a commit
that referenced
this pull request
May 16, 2017
* Build process refactor WIP * Start switch to npm only * IE11 compatibility * Return event so dispatch functions correctly * Fix classNames conditional * IE11 compatibility * Return event so dispatch functions correctly * IE11 compatibility * Fix classNames conditional * Add required attribute to base control, remove for checkbox-group * Rebase against dev * IE11 compatibility * Add args argument to mi18n lookup, attach dom element reference to Control instance, Add support for HTML5 constraint validation for checkbox-groups * rebase from chore/build-process * Sync up dev, add .map files to .gitignore * disableInjectedStyle option (#455) * Bugfix: regeneratorRuntime * Add option to disableInjectedStyle * Other text and option should have different names. Resolves #442 (#456) * Fix syntax
kevinchappell
added a commit
that referenced
this pull request
May 16, 2017
* Build process refactor WIP * Start switch to npm only * IE11 compatibility * Return event so dispatch functions correctly * Fix classNames conditional * IE11 compatibility * Return event so dispatch functions correctly * IE11 compatibility * Fix classNames conditional * Add required attribute to base control, remove for checkbox-group * Rebase against dev * IE11 compatibility * Add args argument to mi18n lookup, attach dom element reference to Control instance, Add support for HTML5 constraint validation for checkbox-groups * rebase from chore/build-process * Sync up dev, add .map files to .gitignore * disableInjectedStyle option (#455) * Bugfix: regeneratorRuntime * Add option to disableInjectedStyle * Other text and option should have different names. Resolves #442 (#456) * Fix syntax
|
Seems like it still injects styles for toggles (kc-toggle) ... used to overwrite that through css, now it shows default styles again, even when disableInjectedStyle is set to true |
|
@aromka is the toggle the only issue? Is this in formRender, formBuilder or both? this feature probably needs to be extended to formRender as I only remember doing it for formBuilder |
|
Only seeing it in formBuilder right now, haven't checked formRender yet. |
|
So all styles disappear except toggle or it's not working at all? |
|
It seems like some other styles are injected as well - see screenshot: https://image.prntscr.com/image/af89edfaac0142b59d4afdfbbc7bc16f.png |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #443