fix(labels): html in xml labels breaks forms #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disabledHTMLLabels option is now set when option.dataType is === 'xml' BREAKING CHANGE: Existing forms created using xml dataType that have html labels will have their labels converted to text Note: the next major release will drop xml support completely
kevinchappell
pushed a commit
that referenced
this pull request
Nov 7, 2018
# [3.0.0](v2.10.9...v3.0.0) (2018-11-07) ### Bug Fixes * **labels:** html in xml labels breaks forms ([#858](#858)) ([ea29e79](ea29e79)) ### BREAKING CHANGES * **labels:** Existing forms created using xml dataType that have html labels will have their labels converted to text Note: the next major release will drop xml support completely
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
kevinchappell
added a commit
that referenced
this pull request
Nov 7, 2018
disabledHTMLLabels option is now set when option.dataType is === 'xml' BREAKING CHANGE: Existing forms created using xml dataType that have html labels will have their labels converted to text Note: the next major release will drop xml support completely
pfranza
pushed a commit
to pfranza/formBuilder
that referenced
this pull request
Nov 21, 2018
disabledHTMLLabels option is now set when option.dataType is === 'xml' BREAKING CHANGE: Existing forms created using xml dataType that have html labels will have their labels converted to text Note: the next major release will drop xml support completely
pfranza
pushed a commit
to pfranza/formBuilder
that referenced
this pull request
Nov 21, 2018
# [3.0.0](kevinchappell/formBuilder@v2.10.9...v3.0.0) (2018-11-07) ### Bug Fixes * **labels:** html in xml labels breaks forms ([kevinchappell#858](kevinchappell#858)) ([ea29e79](kevinchappell@ea29e79)) ### BREAKING CHANGES * **labels:** Existing forms created using xml dataType that have html labels will have their labels converted to text Note: the next major release will drop xml support completely
kevinchappell
added a commit
that referenced
this pull request
Dec 12, 2018
disabledHTMLLabels option is now set when option.dataType is === 'xml' BREAKING CHANGE: Existing forms created using xml dataType that have html labels will have their labels converted to text Note: the next major release will drop xml support completely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disabledHTMLLabels option is now set when option.dataType is === 'xml'
BREAKING CHANGE:
Existing forms created using xml dataType that have html labels will have their labels converted to text
Note: the next major release will drop xml support completely