Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to gookit/color #122

Merged
merged 5 commits into from
Sep 8, 2023
Merged

Change to gookit/color #122

merged 5 commits into from
Sep 8, 2023

Conversation

juev
Copy link
Collaborator

@juev juev commented Sep 8, 2023

This PR was created for several changes:

  1. The library for displaying text with color has been changed. Profiles are used, eliminating the need to use third-party libraries to determine the background color. It’s better to check it again, of course, but it was displayed correctly for me.
  2. After migration, there was no longer a need to use custom functions for text output.
  3. In places where errors are checked, where it is necessary to interrupt program execution, the CheckError function is used.
  4. Added a check for the version in use, and if the version is less than 1.21, we check the version without zero for output. Otherwise with zero, intended to fix Current version not starred #118

For the future, I plan to move work with github into separate interfaces and rework the tests. But this will be in a separate PR.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Summary CoverItUp: kevincobain2000/gobrew

Type master refactoring
coverage 59.1 % 59.2 % +
go-binary-size 5884 KB 5836 KB -
go-mod-dependencies 31 32 +
go-sec-issues 7 6 -
build-time 7 sec 6 sec -

Generated by Cover It Up.
View full report https://coveritup.app/kevincobain2000/gobrew

badge
badge
badge
badge
badge

@juev
Copy link
Collaborator Author

juev commented Sep 8, 2023

As I see, there was an error in the tests:

=== RUN   TestUpgrade
Error: ror]: json: cannot unmarshal object into Go value of type []gobrew.Tag
FAIL	github.com/kevincobain2000/gobrew	49.152s

I'll try to fix it today.

@kevincobain2000
Copy link
Owner

Thanks @juev
I ll check why the charts are not rendering on https://coveritup.app/kevincobain2000/gobrew
Sorry, that's a codecov thing that I added, it was still in beta.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Summary CoverItUp: kevincobain2000/gobrew

Type master refactoring
coverage 59.1 % 59.2 % +
go-binary-size 5884 KB 5836 KB -
go-mod-dependencies 31 32 +
go-sec-issues 7 6 -
build-time 7 sec 7 sec

Generated by Cover It Up.
View full report https://coveritup.app/kevincobain2000/gobrew

badge
badge
badge
badge
badge

@kevincobain2000 kevincobain2000 merged commit 29348d7 into master Sep 8, 2023
22 of 23 checks passed
@kevincobain2000 kevincobain2000 deleted the refactoring branch September 8, 2023 14:29
@juev juev mentioned this pull request Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current version not starred
2 participants