New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pure DOM support and CI test setup #4
Conversation
Conflicts: expect-dom.js
They does not make sense, and fail with higher version jQuery.
Some assertions are removed, so it is consider incompatible with 0.0.1.
- Use innerText in IE8 - Use matchesPolyfill from MDN for IE8
Hi, @kevindente Because you does not reply to this RP. I decided to create a new package in NPM and continuously maintain the project. If you think that is not good, please touch me. Thanks! |
Sorry I've been busy with some family stuff. I'll try to merge your pr today.
|
@kevindente sorry, I have renamed the project to this: I have made some additional changes from the latest commit in the RP. You can diff them offline. |
Hi, @kevindente . Any update? |
Sorry, you closed the pull request, so I wasn't clear if you still wanted me to merge it, or if you just wanted to maintain yours as an independent project. |
OK, the changes have been merged and pushed to npm. Thanks for your help, and sorry it took so long. I bumped the version to 1.0.0 to start being more semver-y |
Basically, I do not want to separate the project and maintain a fork. It could be great that add me as a collaborator. I have some ideas relating to the project, adding some new APIs. I will start a new issue to discuss that. |
Besides, I don't think pump up version to 1.0.0 is a good idea. There are still some issues before bring it to production. |
OK, I finally added you as a collaborator. What kind of issues? I've used it on my own project for a while, and it doesn't have an big bugs that I'm aware of. |
Hi, @kevindente
I have implemented the pure DOM support, add unit test and set up CI test.
Besides, the following modifications:
handle
andhandleWith
assertions, which are meaninglessNote
The CI test result is pointing to my Travis CI result and Sauce Labs result. You can update it after merge.
Please review the changes.