Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pure DOM support and CI test setup #4

Closed
wants to merge 24 commits into from
Closed

Add pure DOM support and CI test setup #4

wants to merge 24 commits into from

Conversation

lijunle
Copy link
Collaborator

@lijunle lijunle commented Jan 29, 2015

Hi, @kevindente

I have implemented the pure DOM support, add unit test and set up CI test.

Besides, the following modifications:

  1. Remove jQuery dependency from implementation
  2. Add git ignore file for node project
  3. Check in jQuery to branch for testing
  4. Update expect.js to the newest version (0.3.1)
  5. Update README examples
  6. Remove handle and handleWith assertions, which are meaningless
  7. Promote the package version to 0.0.2

Note

The CI test result is pointing to my Travis CI result and Sauce Labs result. You can update it after merge.

Please review the changes.

@lijunle
Copy link
Collaborator Author

lijunle commented Feb 10, 2015

Hi, @kevindente

Because you does not reply to this RP. I decided to create a new package in NPM and continuously maintain the project.

If you think that is not good, please touch me.

Thanks!
Junle

@lijunle lijunle closed this Feb 10, 2015
@kevindente
Copy link
Owner

Sorry I've been busy with some family stuff. I'll try to merge your pr today.

On Feb 10, 2015, at 9:33 AM, Junle Li notifications@github.com wrote:

Hi, @kevindente

Because you does not reply to this RP. I decided to create a new package in NPM and continuously maintain the project.

If you think that is not good, please touch me.

Thanks!
Junle


Reply to this email directly or view it on GitHub.

@lijunle
Copy link
Collaborator Author

lijunle commented Feb 10, 2015

@kevindente sorry, I have renamed the project to this:
https://github.com/lijunle/expect-dom.js

I have made some additional changes from the latest commit in the RP. You can diff them offline.

@lijunle
Copy link
Collaborator Author

lijunle commented Feb 11, 2015

Hi, @kevindente . Any update?

@kevindente
Copy link
Owner

Sorry, you closed the pull request, so I wasn't clear if you still wanted me to merge it, or if you just wanted to maintain yours as an independent project.

@kevindente
Copy link
Owner

OK, the changes have been merged and pushed to npm. Thanks for your help, and sorry it took so long. I bumped the version to 1.0.0 to start being more semver-y

@lijunle
Copy link
Collaborator Author

lijunle commented Feb 11, 2015

Basically, I do not want to separate the project and maintain a fork.

It could be great that add me as a collaborator. I have some ideas relating to the project, adding some new APIs. I will start a new issue to discuss that.

@lijunle lijunle mentioned this pull request Feb 11, 2015
@lijunle
Copy link
Collaborator Author

lijunle commented Feb 11, 2015

Besides, I don't think pump up version to 1.0.0 is a good idea. There are still some issues before bring it to production.

@kevindente
Copy link
Owner

OK, I finally added you as a collaborator.

What kind of issues? I've used it on my own project for a while, and it doesn't have an big bugs that I'm aware of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants