Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_mobile? not working #1

Closed
austinthecoder opened this issue Sep 16, 2011 · 3 comments
Closed

is_mobile? not working #1

austinthecoder opened this issue Sep 16, 2011 · 3 comments
Assignees
@kevinelliott
Milestone
0.0.9

Comments

@austinthecoder
Copy link

ua.device is returning 'Mobile' but ua.is_mobile? is returning false

Does this gem have tests?
kevinelliott added a commit that referenced this issue Sep 16, 2011
@kevinelliott
Fixed Issue #1 by checking against symbol instead of string. Also mad…
202ac34 
…e optimizations for how to check for iPhone (ua.is_mobile?(:iphone)). Bumping gem version to 0.0.9.
@ghost ghost assigned kevinelliott Sep 16, 2011
@kevinelliott
Copy link
Owner

Resolved. I'll create an issue separately to track the gem tests. There are no tests now, but I have been planning to create them (as mentioned on the main github page for this gem under Status).

@austinthecoder
Copy link
Author

Oops, missed that section. You'll definitely more traction on this gem with tests. Good luck!

@kevinelliott
Copy link
Owner

Thanks, yep I agree. Didn't expect any traction yet to begin with, but it will encourage me to get full coverage much more quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinelliott kevinelliott

Labels
None yet
Projects
None yet
Milestone
0.0.9
Development

No branches or pull requests
2 participants
@austinthecoder @kevinelliott