Improve bot detection regex #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the bot detection regex by:
- adding a number of missing strings, such as alexa, facebookexternalhit, feedburner, nagios, postrank, pingdom, slurp, and yahoo!
- removing redundant strings such as googlebot and robot (redundant because of the inclusion of a general "bot" string)
- consolidate similar strings ("crawler" and "crawling" became "crawl(er|ing)")
- alphabetize the list of bots
To generate previews on the fly, Google uses the user-agent "Google Web Preview" (the fully-qualified user-agent you see in your server logs may change from time to time) to render images on demand. This commit adds "google web preview" to the bot detection regex.
This commit adds "yandex" to the list of bots, to detect the popular Russian search engine.
|
This would be helpful to us at Causes. |
This commit improves the bot detection regex by:
- adding a number of missing strings, such as alexa,
facebookexternalhit, feedburner, nagios, postrank, pingdom, slurp,
and yahoo!
- removing redundant strings such as googlebot and robot (redundant
because of the inclusion of a general "bot" string) - consolidate
similar strings ("crawler" and "crawling" became "crawl(er|ing)")
- alphabetize the list of bots
To generate previews on the fly, Google uses the user-agent "Google Web Preview" (the fully-qualified user-agent you see in your server logs may change from time to time) to render images on demand. This commit adds "google web preview" to the bot detection regex.
This commit adds "yandex" to the list of bots, to detect the popular Russian search engine.
|
+1 for this! |
|
I'll get this tested and merged in very soon! On Sep 14, 2012, at 4:03 PM, Two Bit Labs notifications@github.com wrote:
|
kevinelliott
added a commit
that referenced
this pull request
Sep 24, 2012
Improve bot detection regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the bot detection regex by: