Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats class #59

Merged
merged 7 commits into from Apr 11, 2016
Merged

Stats class #59

merged 7 commits into from Apr 11, 2016

Conversation

mdespuits
Copy link
Collaborator

Begin statistics calculation into it's own class. Just inherit from Hash and use the existing framework for statistics calculation until we move it into it's own object.

@mdespuits
Copy link
Collaborator Author

@kevinjalbert What do you think? Haven't heard anything... 😉

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a0a2277 on statistics-class into 75605f9 on master.

@mdespuits
Copy link
Collaborator Author

@kevinjalbert Still wanting to continue work on this. Any thoughts?

@kevinjalbert
Copy link
Owner

@mattdbridges Yep, I think having a Statistics class is a good idea other then just using a modified Hash. Just trying to work out #54, I think when we have that in place we could better use the commit-domain object for the statistics.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3956892 on statistics-class into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ebd6b89 on statistics-class into * on master*.

@kevinjalbert
Copy link
Owner

@mdespuits I rebased and fixed up Travis CI's config.

Seems like the specs still pass, and functionally this returns the same output on an example repo I have. I plan to merge this PR in as the concept of a stats class will be helpful in the future (if this project so happens to see more development).

As seen I haven't been activity developing on this project for a while, so I'm just cleaning out issues and PRs currently.

@kevinjalbert kevinjalbert merged commit 5217a7b into master Apr 11, 2016
@kevinjalbert kevinjalbert deleted the statistics-class branch April 11, 2016 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants