Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated parameter #296

Closed
miqwit opened this issue Jan 25, 2019 · 1 comment
Closed

Deprecated parameter #296

miqwit opened this issue Jan 25, 2019 · 1 comment

Comments

@miqwit
Copy link
Contributor

miqwit commented Jan 25, 2019

What Version?

3.0.8

Issue

The current configuration file raises a deprecated warning on symfony 3.4:
Not quoting the scalar "%khill.lavacharts.class%" starting with the "%" indicator character is deprecated since Symfony 3.1 and will throw a ParseException in 4.0 in "vendor/khill/lavacharts/src/Symfony/Bundle/Resources/config/services.yml"

Just quoting the parameters will do fine. I can PR if you don't see any consequential issue.
@kevinkhill
Copy link
Owner

merged #305, will release soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinkhill @miqwit