Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use quotes for parameters (mandatory in symfony 4+) #305

Merged
merged 1 commit into from Jul 11, 2019
Merged

Use quotes for parameters (mandatory in symfony 4+) #305

merged 1 commit into from Jul 11, 2019

Conversation

miqwit
Copy link
Contributor

@miqwit miqwit commented Apr 15, 2019

Quote parameters in ther service.yml file, as required by Symfony 4 and onwards.
This raises a deprecated message in Symfony 3, but fails in Symfony 4 (malformed yaml file)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.16% when pulling 2ff7c83 on miqwit:miqwit-quotes into 2221627 on kevinkhill:3.1.

@kevinkhill kevinkhill merged commit 5823620 into kevinkhill:3.1 Jul 11, 2019
@kevinkhill
Copy link
Owner

thank you for the PR

@kevinkhill kevinkhill mentioned this pull request Jul 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miqwit @coveralls @kevinkhill