Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Changes for adding and firing events #17

Merged
merged 1 commit into from Jan 1, 2015

Conversation

rajivseelam
Copy link
Contributor

There are two problems which I faced:

$ready = new \Khill\Lavacharts\Events\Ready('readyCallBack');

$linechart->events([$ready]);

This was throwing an error because of namespacing problem. is_subclass_of($event, '\Lavacharts\Events\Event') returns false.

2nd Problem:

Registering for events like 'ready' show be done before calling draw. So I have just shifted the position to before draw during render.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6eb2cf8 on rajivseelam:events_not_fired into 2ceb97b on kevinkhill:master.

@kevinkhill kevinkhill self-assigned this Dec 27, 2014
@kevinkhill
Copy link
Owner

I'm on mobile so I can't do much, but your fixes look good. When I get time, I'll test your fixes and merge them in. Thank you for swatting some bugs!

kevinkhill added a commit that referenced this pull request Jan 1, 2015
Make Changes for adding and firing events
@kevinkhill kevinkhill merged commit 1477c01 into kevinkhill:master Jan 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants