Trim matching lines, support utf8 #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
both as options, passed to grep/filereader also closes kevinlacotaco#5
|
@kevinlacotaco Did you have the chance to look at this? It makes the report look a lot tidier. After you merge it I can publish my custom reporter which displays in nicely aligned columns (with auto-padding) for high-readability. This is how it looks in Webstorm with Output Link Filters to the paths become clickable (this runs my fork): |
|
@kevinlacotaco I'm working on another reporter that spits out a markdown format (for github pages), and some rough code for a JSON output that would work with a simple template (it drives this markdown but could do generate some HTML too). (I'm sending you an email now too) |
implemented project adoption - package.json urls point to adopted fork - added note to README.md fail task on pending high prio task added support for bundled reporters - default - markdown (basic) - path (for regexp) changed tests to mocha updated dependencies
|
Closing this as I forked and adopted the project on npm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trim is needed to clean todo's that are nested in a block structure: the indent would show up in the report as offset test, which looks very messy.
Also closes #5 (implements it as an option), matches the node.js convention of using ut8 as default for text.