Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't delete Speakers without Twitter Handles #11

Closed
chrisaldrich opened this issue Aug 25, 2016 · 4 comments
Closed

Can't delete Speakers without Twitter Handles #11

chrisaldrich opened this issue Aug 25, 2016 · 4 comments

Comments

@chrisaldrich
Copy link
Contributor

If an added speaker doesn't have a Twitter handle, the delete button doesn't work to delete them.

@kevinmarks
Copy link
Owner

Put the text of their name in as the twitter handle, as that is what is sent to twitter. I could default it to anon I suppose, but if you do leave it blank, yes, it will not be removable.

@kevinmarks
Copy link
Owner

wondering if I should disallow blank ones

@chrisaldrich
Copy link
Contributor Author

chrisaldrich commented Jan 31, 2017

I can't see a reason it wouldn't be a good idea to do so. Perhaps if it's not a valid Twitter name, it gets wrapped in slighly different code and/or CSS, to indicate it won't resolve to an actual link?

Example: http://boffosocko.com/2016/10/15/notes-from-day-2-of-dodging-the-memory-hole-saving-online-news-friday-october-14-2016/#Peter+Arnett%3A

@kevinmarks
Copy link
Owner

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants