Add support for capturing variables from pattern expressions #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the expansion of pattern expressions when used in a labeled sequence such that the remainder of the sequence is lexically within the match arm so that the variable is in scope. Literal expressions are also included for the sake of generating nicer code by not generating RuleResult in a `match` that is itself immediately matched upon. Fixes #227
kevinmehall
force-pushed
the
continuation
branch
from
e2f4b3d
to
6ecc6f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the expansion of pattern expressions when used in a labeled
sequence such that the remainder of the sequence is lexically within the
match arm so that the variable is in scope.
Literal expressions are also included for the sake of generating nicer
code by not generating RuleResult in a
matchthat is itselfimmediately matched upon.
Fixes #227