Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot delete tempfile on package upload (Sitecore 8) #35

Open
moanrose opened this issue Mar 13, 2015 · 4 comments
Open

Cannot delete tempfile on package upload (Sitecore 8) #35

moanrose opened this issue Mar 13, 2015 · 4 comments

Comments

@moanrose
Copy link

When uploading a package using the /services/package/install/fileupload endpoint in a version compiled for Sitecore 8, i get the following exception:

Exception Details: System.IO.IOException: The process cannot access the file
'C:\projects\ci\cidevelopment\Website\temp\48ca187f-d7f5-4ad9-adce-02343dd46d53.update' because it is being used by another process.
Source Error:
Line 36: public void Dispose()
Line 37: {
Line 38: File.Delete(_tempPackageFile);
Line 39: }
Line 40: }
Source File: c:\projects\ci\Sitecore.Ship\Sitecore.Ship\src\Sitecore.Ship.Infrastructure\IO\TempPackager.cs Line: 38

It seems that the file is still in use by the Sitecore.Updater at this point.

Update: Apparently the error is related to me making a malformed HTTP Post. I tried posting my update package using curl, and there was no error.

@kevinobee
Copy link
Owner

I'll take a look.

-----Original Message-----
From: "moanrose" notifications@github.com
Sent: ‎13/‎03/‎2015 09:13
To: "kevinobee/Sitecore.Ship" Sitecore.Ship@noreply.github.com
Subject: [Sitecore.Ship] Cannot delete tempfile on package upload (Sitecore 8)(#35)

When uploading a package using the /services/package/install/fileupload endpoint in a version compiled for Sitecore 8, i get the following exception:
Exception Details: System.IO.IOException: The process cannot access the file
'C:\projects\ci\cidevelopment\Website\temp\48ca187f-d7f5-4ad9-adce-02343dd46d53.update' because it is being used by another process.
Source Error:
Line 36: public void Dispose()
Line 37: {
Line 38: File.Delete(_tempPackageFile);
Line 39: }
Line 40: }
Source File: c:\projects\ci\Sitecore.Ship\Sitecore.Ship\src\Sitecore.Ship.Infrastructure\IO\TempPackager.cs Line: 38
It seems that the file is still in use by the Sitecore.Updater at this point.

Reply to this email directly or view it on GitHub.

@BobLokerse
Copy link

Is there an estimate when the Sitecore 8 version is going to be available?

@kevinobee
Copy link
Owner

@BobLokerse The first commit towards getting a Sitecore 8.x compatible Ship is in the release/0.4.0 branch.

@kevinobee
Copy link
Owner

I'm going to treat this as a bug as the issue is the exception originating out of the Ship code failing to handle the File.Delete error case appropriately. I will push thin as a fix into the 0.4.0 release.

@kevinobee kevinobee added this to the Version 0.4.0 milestone Sep 13, 2015
@kevinobee kevinobee added the bug label Sep 13, 2015
@kevinobee kevinobee self-assigned this Sep 13, 2015
@kevinobee kevinobee modified the milestones: Version 0.4.1, Version 0.4.0 Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants