Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a watcher for seperator prop #29

Merged
merged 4 commits into from
Sep 19, 2017

Conversation

morloderex
Copy link
Contributor

If parent component changes seperator prop, the displayed value should change immediately and not after input interaction

If parent component changes seperator prop, the displayed value should change immediately and not after input interaction
@codecov
Copy link

codecov bot commented Sep 7, 2017

Codecov Report

Merging #29 into master will increase coverage by 0.32%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   94.11%   94.44%   +0.32%     
==========================================
  Files           1        1              
  Lines          34       36       +2     
  Branches       13       13              
==========================================
+ Hits           32       34       +2     
  Partials        2        2
Impacted Files Coverage Δ
src/vue-numeric.vue 94.44% <100%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc28b47...2353737. Read the comment docs.

@kevinongko
Copy link
Owner

Hi @morloderex,

Thanks for the PR, however please add tests and doc block as in contribution guide

@morloderex
Copy link
Contributor Author

Sorry for the late reply.
i am not confident in creating tests in vue just yet. Can you help me out?

@mo3rfan
Copy link
Contributor

mo3rfan commented Sep 17, 2017

Need something like this for the currency prop too! (I can open a PR for this)

@morloderex tests and docblocks added: morloderex#2 :)

@kevinongko
Copy link
Owner

Strange, I didn't find the changes from @powerinside in this PR, maybe @morloderex need to resubmit the PR?

@mo3rfan
Copy link
Contributor

mo3rfan commented Sep 19, 2017

The changes went into his master branch instead of the feature branch. Sorry about that. Let's try again. PR: morloderex#3

@morloderex
Copy link
Contributor Author

The pr should now be rebased against the correct branch. Thank you so much for helping me @powerinside !

The watcher does not trigger if the new & old value is same anyway
@kevinongko kevinongko merged commit 0ceb36c into kevinongko:master Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants