-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a watcher for seperator prop #29
Add a watcher for seperator prop #29
Conversation
If parent component changes seperator prop, the displayed value should change immediately and not after input interaction
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 94.11% 94.44% +0.32%
==========================================
Files 1 1
Lines 34 36 +2
Branches 13 13
==========================================
+ Hits 32 34 +2
Partials 2 2
Continue to review full report at Codecov.
|
Hi @morloderex, Thanks for the PR, however please add tests and doc block as in contribution guide |
Sorry for the late reply. |
Need something like this for the currency prop too! (I can open a PR for this) @morloderex tests and docblocks added: morloderex#2 :) |
Strange, I didn't find the changes from @powerinside in this PR, maybe @morloderex need to resubmit the PR? |
The changes went into his master branch instead of the feature branch. Sorry about that. Let's try again. PR: morloderex#3 |
The pr should now be rebased against the correct branch. Thank you so much for helping me @powerinside ! |
The watcher does not trigger if the new & old value is same anyway
If parent component changes seperator prop, the displayed value should change immediately and not after input interaction