Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dev to choose navbar color light/dark (class) #43

Closed
cavasinf opened this issue Dec 21, 2021 · 2 comments · Fixed by #3
Closed

Allow dev to choose navbar color light/dark (class) #43

cavasinf opened this issue Dec 21, 2021 · 2 comments · Fixed by #3
Labels
Feature Feature requested Status: Has PR Waiting in PR to be merge
Milestone

Comments

@cavasinf
Copy link
Collaborator

With the current state,
Navbar color is hard coded (navbar-light):

<header class="navbar navbar-expand-md navbar-light d-print-none">

<div class="navbar navbar-light">

We need to allow dev to choose between navbar dark or light.

⚠️ Changes must be done with layer vertical and horizontal ⚠️
SEE #3

@cavasinf cavasinf added Status: Needs Review Not under investigation Feature Feature requested labels Dec 21, 2021
@kevinpapst
Copy link
Owner

kevinpapst commented Dec 21, 2021

And in line

<div class="navbar navbar-light">

When I set body class="theme-dark" then the navbar is dark, even if it has the class navbar-light.

@cavasinf
Copy link
Collaborator Author

theme-dark override every -light class configuration.

For me it is a normal behavior, do you see something wrong with that ?

What I want to do is:
Horizontal :

Vertical:

Vertical condensed:

@cavasinf cavasinf added Status: Has PR Waiting in PR to be merge and removed Status: Needs Review Not under investigation labels Jan 3, 2022
@cavasinf cavasinf added this to the 1.0 milestone Jan 3, 2022
@cavasinf cavasinf linked a pull request Jan 14, 2022 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature requested Status: Has PR Waiting in PR to be merge
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants