Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create carousel.html.twig #104

Merged
merged 5 commits into from
Aug 31, 2022
Merged

Create carousel.html.twig #104

merged 5 commits into from
Aug 31, 2022

Conversation

wucherpfennig
Copy link
Contributor

Description

Add carousel component. see #100

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I updated the documentation (see here)
  • I agree that this code will be published under the MIT license

@wucherpfennig wucherpfennig mentioned this pull request Jul 6, 2022
Merged
5 tasks
@cavasinf cavasinf added Status: Needs Review Not under investigation Feature Feature requested labels Jul 25, 2022
@cavasinf cavasinf linked an issue Jul 25, 2022 that may be closed by this pull request
Component - Carousel #100
Closed
@kevinpapst
Copy link
Owner

I totally forgot about this PR, so sorry!

This is huge, could you add a short documentation page with an example (which I would then add to the demo app)?

@wucherpfennig
Copy link
Contributor Author

wucherpfennig commented Aug 23, 2022 •
edited

I have added the required docs.

I will add all config options asap

@wucherpfennig
Copy link
Contributor Author

Updated docs. It's a start. far from perfect.

kevinpapst
kevinpapst previously approved these changes Aug 31, 2022
View reviewed changes
Copy link
Owner

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @wucherpfennig 👍

kevinpapst
kevinpapst approved these changes Aug 31, 2022
View reviewed changes
Copy link
Owner

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed a couple of tiny things:

  • incoming variables changed from underscore to camelCase naming
  • formatted docs and added links

@kevinpapst kevinpapst merged commit 7519375 into kevinpapst:main Aug 31, 2022
@cavasinf cavasinf removed the Status: Needs Review Not under investigation label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpapst kevinpapst kevinpapst approved these changes

Assignees
No one assigned
Labels
Feature Feature requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component - Carousel
3 participants
@wucherpfennig @kevinpapst @cavasinf