Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theme override doc #115

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Update theme override doc #115

merged 1 commit into from
Sep 23, 2022

Conversation

cavasinf
Copy link
Collaborator

Description

Add more detailed DOC about theme override

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I updated the documentation (see here)
  • I agree that this code will be published under the MIT license

@cavasinf cavasinf added Documentation Improvements or additions to documentation Status: Needs Review Not under investigation labels Sep 22, 2022
@cavasinf cavasinf added this to the 1.0 milestone Sep 22, 2022
@kevinpapst
Copy link
Owner

@cavasinf you write "add more detailed doc" but the PR includes only the adapted scss file.
Can you share more details? Because I do not get it. Is this your set of fixes for Tabler? What does it do?

@cavasinf
Copy link
Collaborator Author

cavasinf commented Sep 23, 2022

I've just added more scss color override like light backgrounds, border colors and text colors.
They were not overridden by variables colors of Tabler's default css.

I mean doc because it is not used by the Bundle. It's just an example if devs want to change default Tabler's colors.

@kevinpapst kevinpapst merged commit a2d91a6 into main Sep 23, 2022
@kevinpapst kevinpapst deleted the cavasinf-theme-doc branch September 23, 2022 12:43
@kevinpapst
Copy link
Owner

Okay then 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Status: Needs Review Not under investigation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants