Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress bar component #117

Merged
merged 4 commits into from
Oct 4, 2022

Conversation

cavasinf
Copy link
Collaborator

Description

Add progress bar component

progress bar

{{ progressBar() }}

{{ progressBar({current : 1}) }}

{{ progressBar({current : 2, max : 3, min : -1}) }}

{{ progressBar({current : 2, max : 3}) }}

{{ progressBar({current : 2, max : 3, color : 'bg-red'}, {backgroundColor : 'bg-grey'}) }}

{{ progressBar({current : 2, max : 3, color : 'bg-green'}, {progressSize : 'progress-sm'}) }}

{{ progressBar({current : 2, max : 3, color : 'bg-orange'}, {style : 'height: 20px;'}) }}

{{ progressBar({color : 'bg-red'}, {backgroundColor : 'bg-grey'}) }}

{{ progressBar({current :2, max: 5, color : 'bg-red', striped : true}) }}

{{ progressBar({current :2, max: 5, striped : true, animated: true}) }}

{{ progressBars([
    {current :15, max: 100},
    {current :30, max: 100, color: 'bg-success'},
    {current :20, max: 100, color: 'bg-danger'},
]) }}

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I updated the documentation (see here)
  • I agree that this code will be published under the MIT license

@cavasinf cavasinf added Status: Needs Review Not under investigation Feature Feature requested labels Sep 30, 2022
@cavasinf cavasinf added this to the 1.1 milestone Sep 30, 2022
## ProgressBar (single)

Progress Bar has been implemented to simplify the use of the Tabler Progress Bar component.
`ProgressBar()` is a Shortcut of `ProgressBars()` with an array of ONE item.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use progress_bar and progress_bars please.

We already have status_dot and status_indicator.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure 👍

@cavasinf cavasinf added Status: Reviewed Has staff reply/investigation and removed Status: Needs Review Not under investigation labels Oct 3, 2022
Copy link
Owner

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍
Just waiting with the merge, until I find time to create a demo page.

@kevinpapst
Copy link
Owner

I can't push changes 😢 time wasted...

Copy link
Owner

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rename the file and use underscore

docs/components-progress-bar.md Outdated Show resolved Hide resolved
docs/components-progress-bar.md Outdated Show resolved Hide resolved
@cavasinf
Copy link
Collaborator Author

cavasinf commented Oct 4, 2022

It's not common for me to have underscores inside filename.
Looking at doc and layer files, they have hyphens, but components no.. bit disturbing.

@kevinpapst
Copy link
Owner

Yeah, true. Looks kind of consequent inconsequent 😁
But at least all components and includes use hyphens, so filename matches the macro name.
Thanks for the change!

@kevinpapst kevinpapst merged commit 70910a0 into kevinpapst:main Oct 4, 2022
@cavasinf cavasinf deleted the feature/progress-bar branch October 4, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature requested Status: Reviewed Has staff reply/investigation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants