Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update theme.scss #124

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Update theme.scss #124

merged 1 commit into from
Oct 27, 2022

Conversation

cavasinf
Copy link
Collaborator

@cavasinf cavasinf commented Oct 27, 2022 •
edited
Loading

Description

Huge update from Tabler about how they handle colors.
Not good enough though ➡️ tabler/tabler#1335

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I updated the documentation (see here)
  • I agree that this code will be published under the MIT license

@cavasinf cavasinf added Documentation Improvements or additions to documentation Status: Needs Review Not under investigation labels Oct 27, 2022
@cavasinf cavasinf added this to the 1.1 milestone Oct 27, 2022
kevinpapst
kevinpapst approved these changes Oct 27, 2022
View reviewed changes
Copy link
Owner

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering what file that is, but then I saw docs/ directory.

Thanks 👍 do you think there will be more updates to this or can I merge right away?

@cavasinf
Copy link
Collaborator Author

do you think there will be more updates

Depends on Tabler response time + fix.
But they are very slow to treat/implement things.. so I'll make another PR when fixed.

Good to go for merge right away 👍

@cavasinf cavasinf added Status: Reviewed Has staff reply/investigation and removed Status: Needs Review Not under investigation labels Oct 27, 2022
@kevinpapst
Copy link
Owner

Yeah, unfortunately communication with the community is not his best skill.

@kevinpapst kevinpapst merged commit 84ba9d7 into main Oct 27, 2022
@kevinpapst kevinpapst deleted the cavasinf-theme branch October 27, 2022 10:08
@cavasinf cavasinf mentioned this pull request Nov 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpapst kevinpapst kevinpapst approved these changes

Assignees
No one assigned
Labels
Documentation Improvements or additions to documentation Status: Reviewed Has staff reply/investigation
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cavasinf @kevinpapst