Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change .wrapper to .page #74

Merged
merged 1 commit into from
Mar 26, 2022
Merged

Change .wrapper to .page #74

merged 1 commit into from
Mar 26, 2022

Conversation

cavasinf
Copy link
Collaborator

@cavasinf cavasinf commented Mar 26, 2022

Description

In case of the footer that is not on the bottom of the page,
the only diff I've found with the demo is that class: https://preview.tabler.io/empty.html

Maybe BC Break ? not on my side.

Note: in the fullpage.html.twig, we have already changed that class.

With .wrapper:
Capture d’écran 2022-03-26 à 15 11 58

With .page:
Capture d’écran 2022-03-26 à 15 11 49

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I updated the documentation (see here)
  • I agree that this code will be published under the MIT license

@cavasinf cavasinf added Status: Needs Review Not under investigation Feature Feature requested labels Mar 26, 2022
cavasinf pushed a commit to TeamAllsoftware/TablerBundle that referenced this pull request Mar 26, 2022
Copy link
Owner

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@kevinpapst kevinpapst merged commit 6587c37 into main Mar 26, 2022
@kevinpapst kevinpapst deleted the Change-wrapper-to-page branch March 26, 2022 19:02
@cavasinf cavasinf added Status: Reviewed Has staff reply/investigation and removed Status: Needs Review Not under investigation labels Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature requested Status: Reviewed Has staff reply/investigation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants