Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix callout embed #93

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Fix callout embed #93

merged 2 commits into from
Jun 10, 2022

Conversation

kevinpapst
Copy link
Owner

Description

Needed changes after #90

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I updated the documentation (see here)
  • I agree that this code will be published under the MIT license

@kevinpapst kevinpapst added the Bug Something isn't working label Jun 9, 2022
@kevinpapst kevinpapst requested a review from cavasinf June 9, 2022 12:39
cavasinf
cavasinf reviewed Jun 10, 2022
View reviewed changes
Copy link
Collaborator

@cavasinf cavasinf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kevinpapst kevinpapst merged commit 395bbc9 into main Jun 10, 2022
@kevinpapst kevinpapst deleted the fix-callout branch June 10, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cavasinf cavasinf cavasinf left review comments

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevinpapst @cavasinf