Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup FOS user references #94

Merged
merged 4 commits into from
Jun 19, 2022
Merged

Cleanup FOS user references #94

merged 4 commits into from
Jun 19, 2022

Conversation

kevinpapst
Copy link
Owner

@kevinpapst kevinpapst commented Jun 19, 2022

Description

Some random cleanup commits with tiny BC break if someone relied on the fos_user_registration_register class or used the fos_user_content block (which I hope nobody did).

My main purpose was to get rid of the last fos_user references from the AdminLTE era - fixes #33

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I updated the documentation (see here)
  • I agree that this code will be published under the MIT license

@kevinpapst kevinpapst requested a review from cavasinf June 19, 2022 09:44
@kevinpapst kevinpapst changed the title Cleanup Cleanup FOS user references Jun 19, 2022
@kevinpapst kevinpapst merged commit f5b7d75 into main Jun 19, 2022
@kevinpapst kevinpapst deleted the cleanup branch June 19, 2022 13:05
@cavasinf
Copy link
Collaborator

Review requested but already merged 😄

Just to remember, there is also a PR on that #53
Modifying mostly those same files.

@cavasinf cavasinf added Bug Something isn't working Status: Reviewed Has staff reply/investigation labels Jun 21, 2022
@kevinpapst
Copy link
Owner Author

Sorry, I really needed that at this time and forgot that it was weekend ... ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Status: Reviewed Has staff reply/investigation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove FOSUser references
2 participants