Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unused and some very opinionated code from the forms theme #97

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

kevinpapst
Copy link
Owner

Description

This is a BC break if you used the form these provided by this bundle.
Otherwise it is just a cleanup of code that does not belong here.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I updated the documentation (see here)
  • I agree that this code will be published under the MIT license

@kevinpapst
Copy link
Owner Author

The code which I removed should not be in here, it is the responsibility of the project to decide how your forms should look like. Floating labels work different from regular forms. Then also there were leftovers from certain datepicker-picker libraries in there, which should not interfere with your customizations.

@wucherpfennig @cavasinf can you have a quick look if your projects are negatively affected / if the docs are sufficient to clarify the process.

@kevinpapst kevinpapst merged commit 9ab3772 into main Jul 1, 2022
@kevinpapst kevinpapst deleted the forms branch July 1, 2022 21:22
@wucherpfennig
Copy link
Contributor

Sorry for not providing feedback. I did check and it seams reasonable. I will find out as soon as there is an obvious error aka "scream testing" 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants