Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Scrutinizer to run code sniffer #158

Closed
kevinpapst opened this issue Jun 6, 2018 · 2 comments · Fixed by #172
Closed

Setup Scrutinizer to run code sniffer #158

kevinpapst opened this issue Jun 6, 2018 · 2 comments · Fixed by #172
Assignees
Milestone

Comments

@kevinpapst
Copy link
Member

... and more code quality stuff, like:

kevinpapst added a commit that referenced this issue Jun 7, 2018
kevinpapst added a commit that referenced this issue Jun 7, 2018
kevinpapst added a commit that referenced this issue Jun 7, 2018
@kevinpapst
Copy link
Member Author

Scrutinizer config was added but could use some love AKA improved it, e.g. like this:
https://github.com/thephpleague/skeleton/blob/master/.scrutinizer.yml

@kevinpapst kevinpapst self-assigned this Jun 7, 2018
@kevinpapst kevinpapst added this to the 0.2 milestone Jun 13, 2018
kevinpapst added a commit that referenced this issue Jun 22, 2018
* use php-cs-fixer instead of phpcodesniffer
* updated scrutinizer config
* adjusted code yules to all files
* updated CONTRIBUTING guidelines
@kevinpapst kevinpapst modified the milestone: 0.2 Jun 23, 2018
@lock
Copy link

lock bot commented Nov 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant