Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes #2655

Merged
merged 11 commits into from
Jul 9, 2021
Merged

Bugfixes #2655

merged 11 commits into from
Jul 9, 2021

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Jul 9, 2021 •
edited
Loading

Description

see commits, many small improvements

Fixes #2576
Fixes #2200

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added the bug label Jul 9, 2021
@kevinpapst kevinpapst added this to the 1.15 milestone Jul 9, 2021
@codecov
Copy link

codecov bot commented Jul 9, 2021 •
edited
Loading

Codecov Report

Merging #2655 (38c76fc) into master (9ddb87a) will decrease coverage by 0.03%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master    #2655      +/-   ##
============================================
- Coverage     92.54%   92.51%   -0.04%     
- Complexity     7106     7111       +5     
============================================
  Files           647      647              
  Lines         21193    21196       +3     
============================================
- Hits          19613    19609       -4     
- Misses         1580     1587       +7
Impacted Files Coverage Δ
src/Form/ActivityEditForm.php 84.78% <70.83%> (-15.22%) ⬇️
src/Entity/Timesheet.php 98.83% <100.00%> (+0.01%) ⬆️
src/EventSubscriber/Actions/ProjectSubscriber.php 100.00% <100.00%> (ø)
...rc/Reporting/ProjectDetails/ProjectDetailsForm.php 100.00% <100.00%> (ø)
src/Repository/TimesheetRepository.php 89.27% <0.00%> (-0.18%) ⬇️
src/Form/Type/ProjectType.php 97.22% <0.00%> (+2.77%) ⬆️

@kevinpapst kevinpapst linked an issue Jul 9, 2021 that may be closed by this pull request
Reassigning activity to other customer/project does not adapt timesheet entries #2576
Closed
@kevinpapst kevinpapst merged commit 2583fdf into master Jul 9, 2021
@kevinpapst kevinpapst deleted the bugfixes branch July 9, 2021 22:37
kevinpapst added a commit that referenced this pull request Jul 13, 2021
@kevinpapst
small bugfixes (#2655)
cf726fe 
* improve report visibility
* fix timesheet duration, which breaks validation
* added contributing section in README
* do not allow to change project for existing activities - fixes #2576
* bump theme version to fix FOSUserBundle dependency
* use entity color instead of inherited one - fixes #2200
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.15
1 participant
@kevinpapst