Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar view: more space for business hours #530

Closed
blochwitz opened this issue Jan 30, 2019 · 14 comments · Fixed by #784
Closed

Calendar view: more space for business hours #530

blochwitz opened this issue Jan 30, 2019 · 14 comments · Fixed by #784
Milestone

Comments

@blochwitz
Copy link

Hi Kevin,

in the calendar view the business hours (in our case 7am to 5pm) could be have more space as the hours outside.

we suggests the following options:

  1. the hours outside the defined business hours are in a non viewable area (behind the header/footer of the calendar) or
  2. they could be grouped like 12-6am and 5pm-12am

bildschirmfoto 2019-01-30 um 08 10 59
bildschirmfoto 2019-01-30 um 08 11 24

@kevinpapst
Copy link
Member

The calendar is not self-made and I don't have plans to "hack it".
But yu could research if there is support for something like this in: https://fullcalendar.io

@blochwitz
Copy link
Author

Okay. The calendar is full customizable. how did you implement it in kimai2?

@kevinpapst
Copy link
Member

@blochwitz
Copy link
Author

Okay, thanks. i'll take a look inside the Controller...

@kevinpapst
Copy link
Member

Cool!
Yes, there are a lot of improvements possible, but the calendar currently has not the highest priority on my list, so I could use some help :-)

@blochwitz
Copy link
Author

I'm sorry but i have two more questions:
where can i find the JS-Library off FullCalendar and where did you defined app.user.getPreferenceValue('calendar.initial_view')

@kevinpapst
Copy link
Member

I don't understand your questions:
Which JSLibrary: the original one in node_modules? the compiled version? Its GitHub URL?
The initial view can be set by the user in his preferences.

@kevinpapst kevinpapst added the help wanted needs a developer who want to add this feature label Feb 7, 2019
@blochwitz
Copy link
Author

Hi Kevin,

let me explain what i have done:

In the file templates > calendar > user.html.twig i tried to change the function of calendar like it is explained at https://fullcalendar.io but it doesn't work so i asked me if you changed something in the JSLibrary of full calendar?

@kevinpapst
Copy link
Member

No library is modified. The build process only takes all libraries and puts them together in one file.
Maybe a version problem: https://github.com/kevinpapst/kimai2/blob/master/yarn.lock#L2549
Did you clear your cache after changing the template?

@kevinpapst
Copy link
Member

The requested feature is not possible or at least not out of the box.
According to the docs and the screenshots, only business hour highlighting is possible:
https://fullcalendar.io/docs/v3/business-hours

@kevinpapst
Copy link
Member

I was too quick and finally found a setting:

I will make those configurable. BUT: if they are set the week and day view will NOT displayed if the complete record is outside this timeframe.

Example: you configure 08:00 - 18:00 as visible, then a record from 06:00 - 07:30 will not be shown.

I will make these settings configurable.

Best would be to provide system default values and allow to customize them via a user config. What do you think?

@kevinpapst kevinpapst reopened this May 13, 2019
@kevinpapst kevinpapst added feature request and removed help wanted needs a developer who want to add this feature wontfix labels May 13, 2019
@kevinpapst kevinpapst added this to the 1.0 milestone May 13, 2019
@kevinpapst kevinpapst mentioned this issue May 14, 2019
4 tasks
@blochwitz
Copy link
Author

blochwitz commented May 14, 2019

Hi Kevin, sounds great. Thanks for the investigation. A configurable setting in the user settings will be a good solution...

@kevinpapst
Copy link
Member

kevinpapst commented May 19, 2019

Calendar update merged to master. Two new system-wide settings are available:

  • hide weekends
  • start and end time for visible hours (e.g. you can limit the visible time-range from 06:00 to 20:00)

@lock
Copy link

lock bot commented Jul 18, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Jul 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants