Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added command to create invoices via bash #1574

Merged
merged 14 commits into from
Mar 20, 2020
Merged

added command to create invoices via bash #1574

merged 14 commits into from
Mar 20, 2020

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Mar 19, 2020

Description

  • new event for created invoices
  • cache invoice number in invoice-model for uniqueness and multiple inv… …
  • more customer fields during invoice hydration
  • added command to create invoices via bash

TODO

  • tests
  • documentation

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #1574 into master will decrease coverage by 0.10%.
The diff coverage is 89.66%.

@@             Coverage Diff              @@
##             master    #1574      +/-   ##
============================================
- Coverage     92.09%   91.99%   -0.11%     
- Complexity     4570     4647      +77     
============================================
  Files           430      432       +2     
  Lines         14107    14354     +247     
============================================
+ Hits          12992    13205     +213     
- Misses         1115     1149      +34     
Impacted Files Coverage Δ Complexity Δ
src/Controller/InvoiceController.php 79.53% <71.05%> (-6.47%) 49.00 <4.00> (-21.00)
src/Utils/FileHelper.php 88.23% <84.61%> (+9.28%) 7.00 <4.00> (-2.00) ⬆️
src/Invoice/ServiceInvoice.php 87.05% <90.19%> (+4.20%) 65.00 <34.00> (+33.00)
src/Command/InvoiceCreateCommand.php 91.98% <91.98%> (ø) 61.00 <61.00> (?)
src/Entity/Invoice.php 100.00% <100.00%> (ø) 34.00 <0.00> (ø)
src/Entity/InvoiceTemplate.php 89.02% <100.00%> (-10.98%) 50.00 <2.00> (+2.00) ⬇️
src/Event/InvoiceCreatedEvent.php 100.00% <100.00%> (ø) 2.00 <2.00> (?)
src/Form/Type/InvoiceTemplateType.php 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
.../Invoice/Hydrator/InvoiceModelCustomerHydrator.php 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...c/Invoice/Hydrator/InvoiceModelDefaultHydrator.php 100.00% <100.00%> (ø) 1.00 <0.00> (ø)
... and 6 more

@kevinpapst kevinpapst merged commit b8c5323 into master Mar 20, 2020
@kevinpapst kevinpapst deleted the invoice-command branch March 20, 2020 12:14
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant