Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New report + UI improvements #2494

Merged
merged 11 commits into from
Apr 7, 2021
Merged

New report + UI improvements #2494

merged 11 commits into from
Apr 7, 2021

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Apr 7, 2021

Description

Wild mixture of small improvements:

  • improve visual availability of reports (split reports in sections + more buttons)
  • remove search option for toolbar order and orderby
  • make sure that badges text can be read
  • prevent broken SAML exception message
  • clarify delete search favorite
  • unified reports and removed duplicated code

New report:

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@codecov
Copy link

Codecov bot commented Apr 7, 2021

Codecov Report

Merging #2494 (fc7aea0) into master (cdad591) will increase coverage by 0.02%.
The diff coverage is 95.83%.

@@             Coverage Diff              @@
##             master    #2494      +/-   ##
============================================
+ Coverage     92.60%   92.63%   +0.02%     
- Complexity     6532     6549      +17     
============================================
  Files           593      596       +3     
  Lines         19428    19502      +74     
============================================
+ Hits          17992    18065      +73     
- Misses         1436     1437       +1     
Impacted Files Coverage Δ Complexity Δ
src/Controller/ReportingController.php 80.00% <ø> (-13.34%) 6.00 <0.00> (-26.00)
...rc/Controller/Reporting/ReportByUserController.php 94.59% <94.59%> (ø) 19.00 <19.00> (?)
...Controller/Reporting/ReportUsersListController.php 95.50% <95.50%> (ø) 15.00 <15.00> (?)
src/Controller/Auth/SamlController.php 88.23% <100.00%> (+3.86%) 15.00 <0.00> (+2.00)
...rc/EventSubscriber/Actions/ReportingSubscriber.php 100.00% <100.00%> (ø) 5.00 <0.00> (+1.00)
src/EventSubscriber/MenuSubscriber.php 96.05% <100.00%> (ø) 29.00 <0.00> (ø)
src/Form/Toolbar/AbstractToolbarForm.php 81.81% <100.00%> (ø) 62.00 <0.00> (ø)
src/Reporting/AbstractUserList.php 100.00% <100.00%> (ø) 3.00 <3.00> (?)
src/Reporting/Report.php 100.00% <100.00%> (ø) 7.00 <4.00> (+3.00)
src/Reporting/ReportingService.php 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
... and 5 more

@kevinpapst kevinpapst added this to the 1.14 milestone Apr 7, 2021
@kevinpapst kevinpapst changed the title UI improvements New report + UI improvements Apr 7, 2021
@kevinpapst kevinpapst marked this pull request as ready for review April 7, 2021 20:19
@kevinpapst kevinpapst merged commit 2ce6e81 into master Apr 7, 2021
@kevinpapst kevinpapst deleted the search branch April 7, 2021 20:20
kevinpapst added a commit that referenced this pull request Jul 13, 2021
@github-actions GitHub Actions bot locked and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant