Add json method to allow posting stringified json contents #100
Conversation
|
FWIW, I realized that you can do this with the current code base by specifying the contentType and using However, I still would be nice to have this convenience method. |
| throws HttpRequestException { | ||
| contentType(CONTENT_TYPE_JSON); | ||
| try { | ||
| openOutput(); |
There was a problem hiding this comment.
You could just call send here instead which would make this method a little simpler:
contentType(CONTENT_TYPE_JSON);
send(jsonString);There was a problem hiding this comment.
Is this a PR worth adding? If so, I'll update the code. Otherwise, no offense taken.
When I first submitted it, I didn't realize that it could be sent using a combination of 'contentType' and send and thought I would need to openOutput myself. form caught my attention and got fixated on that.
There was a problem hiding this comment.
Is this a PR worth adding?
Yeah, I think so, given how common working with JSON is.
There was a problem hiding this comment.
Alright - change has been made.
| * @return this request | ||
| * @throws HttpRequestException | ||
| */ | ||
| public HttpRequest json(final String jsonString) { |
There was a problem hiding this comment.
This should probably be final CharSequence to be consistent with the signature of the other helpers.
|
Closing this as it is super stale. |
This is a one-method addition to allow for sending a json body in the request. It doesn't add any dependencies since the signature just takes the stringified json.