Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to account name if official name not available #16

Closed
davestimpert opened this issue Feb 9, 2019 · 1 comment · Fixed by #28
Closed

Fall back to account name if official name not available #16

davestimpert opened this issue Feb 9, 2019 · 1 comment · Fixed by #28

Comments

@davestimpert
Copy link

davestimpert commented Feb 9, 2019

I have an account who's official_name is null, so it would be nice if I could have it fall back to name if official_name is null. This is tricky, though, because columns are configurable.

@kevinschaich
Copy link
Owner

Hey @davestimpert – I've been meaning to tackle this for a while but I needed to refactor a couple things first so that we maintain backwards compatibility.

After some thinking, I think it's better to implement this at the provider level rather than the global level. The Plaid provider should be smart enough to preference the most complete name so that Mintable doesn't need to know about the internals of what's returned by Plaid.

I think #28 / the v1.2.1 release should fix this for you. You'll want to run yarn migrate if you're still on an older version of Mintable, and then changing the following in mintable.config.json should do the trick:

{
  ...
  "TRANSACTION_COLUMNS": [
    "date",
    "amount",
    "name",
-   "account_details.official_name",
+  "account"
    "category.0",
    "category.1",
    "pending"
  ],
  ...
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants