Cross Platform Notifications (linux, mac, windows). #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is perfect, the contribution is very much appreciated! I will clean up the interface, remove the unnecessary code you mentioned, and put out a new release today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple implementation wrapping https://github.com/0xAX/notificator which enables mac and windows notifications, obviously linux is all ready implemented.
The interface
Notify(string, string) errorcould be removed in favour of just one concrete implementation using the aforementioned library, but I didn't want to gut the code, merely extend it.This results in a little bit of superfluous code, namely the type aliases, and the switch statement that instantiates the specific implementation, can both be done away with. Though I leave that decision up to you!