Use a separate socket path to publish so pomo can publish and listen on different sockets #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #49
This is a breaking change for anyone that previously used "publish" mode, since the configuration for the socket path has changed.
I thought about what it would take to make this backwards compatible, and I'm wondering if it's worth the effort. It would need to check for the case where
publishistrue, and nopublishSocketPathis set. In that case,socketPathwould be copied topublishSocketPath, and each place I just changed in this PR to do both things would need to only do the publish thing, but only in this case.Instead, I suggest an error indicating the change. That way, anyone using
publishwill know what happened and what they need to change.