Fix - Webcam not showed on iOS devices and Open URL not work #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for skyoffice ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
kevinshen56714
requested changes
Mar 5, 2023
There was a problem hiding this comment.
Thank you so much again! These are great fixes, I have just some minor comments. @DaxChen let us know how you think if you have time :)
I'd be excited if you can implement a SFU solution like you mentioned 👍 ! Our current video streaming actually doesn't work on some networks/devices, and the P2P architecture also doesn't scale well. So I'm looking forward to your changes!!
kevinshen56714
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR fixes 2 things:
Before:
After:
I've detected another issue that is fixed with another PR that I've uploaded this week refactoring to be mobile friendly and adding the action buttons on touch devices.
#65
@DaxChen @kevinshen56714 If anyone has time, take a look at it. If you need any clarification, let me know 👍
By the way.. I'm thinking about do a refactor of the WebRTC implementing some solution like mediasoup (https://mediasoup.org).. please say me if you find interesting or there is something whit higher priority