Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prevActiveNotes race condition, and don't add 'active' style to disabled piano keys #46

Merged
merged 3 commits into from Jun 30, 2019
Merged

Fix prevActiveNotes race condition, and don't add 'active' style to disabled piano keys #46

merged 3 commits into from Jun 30, 2019

Conversation

kevinsqi
Copy link
Owner

@kevinsqi kevinsqi commented Jun 30, 2019 •
edited

prevActiveNotes race condition could cause onPlayNoteInput and onStopNoteInput's prevActiveNotes to return the incorrect result.

@kevinsqi kevinsqi merged commit 7cfe138 into master Jun 30, 2019
@kevinsqi kevinsqi deleted the disabled-keys-should-not-be-active branch June 30, 2019 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kevinsqi