Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.8 Category Admin Fix #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

2.8 Category Admin Fix #7

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 3, 2014

URL changes in 2.8 was causing draggable not to work in the category admin.

So the following URL index.php?/cp/admin_content/change_category_order?cat_id=1&group_id=1&order=up'was getting split into ["index.php?/cp/admin_content/change_category_order?cat_id=1", "group_id=1", "order=up"] with the issue being the the cat_id parameter.

This fix changes the split seperator into a regex so it accounts for both '?' and '&', which now returns ["index.php", "/cp/admin_content/change_category_order", "cat_id=4", "group_id=1", "order=up"] fixing the issue.

@stemwinder
Copy link

Thanks for the fix, Keiron. Not sure what a pull request as simple as this can't be merged already.

@stemwinder
Copy link

FYI, I've forked and committed your suggested change, Keiron (https://github.com/stemwinder/draggable). I'll try to keep it updated as best I can. Would be grateful for other contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant