Skip to content

Commit

Permalink
app: fix usage help of options separated by dashes
Browse files Browse the repository at this point in the history
The EAL options and app-specific options are separated
with double dashes.

The help of testpmd, test-acl and pdump were missing
the dashes after EAL options.
Note: testpmd was completely missing the EAL options.

Fixes: af75078 ("first public release")
Fixes: 26c057a ("acl: new test-acl application")
Fixes: b2854d5 ("app/pdump: support multi-core capture")
Cc: stable@dpdk.org

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
  • Loading branch information
tmonjalo authored and david-marchand committed Apr 25, 2020
1 parent 611faa5 commit a658775
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion app/pdump/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ static uint8_t multiple_core_capture;
static void
pdump_usage(const char *prgname)
{
printf("usage: %s [EAL options]"
printf("usage: %s [EAL options] --"
" --["CMD_LINE_OPT_MULTI"]\n"
" --"CMD_LINE_OPT_PDUMP" "
"'(port=<port id> | device_id=<pci id or vdev name>),"
Expand Down
2 changes: 1 addition & 1 deletion app/test-acl/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
#include <rte_lcore.h>
#include <rte_ip.h>

#define PRINT_USAGE_START "%s [EAL options]\n"
#define PRINT_USAGE_START "%s [EAL options] --\n"

#define RTE_LOGTYPE_TESTACL RTE_LOGTYPE_USER1

Expand Down
2 changes: 1 addition & 1 deletion app/test-pmd/parameters.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
static void
usage(char* progname)
{
printf("usage: %s "
printf("usage: %s [EAL options] -- "
#ifdef RTE_LIBRTE_CMDLINE
"[--interactive|-i] "
"[--cmdline-file=FILENAME] "
Expand Down

0 comments on commit a658775

Please sign in to comment.